Do not cancel concurrent CI matrix jobs #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
reviewed
Jul 1, 2025
.github/workflows/test.yml
Outdated
| @@ -77,6 +77,7 @@ jobs: | |||
| test: | |||
| strategy: | |||
| matrix: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
According to the following docs, it seems like this needs to be one level up: https://docs.github.com/en/actions/how-tos/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#handling-failures
There was a problem hiding this comment.
Whoops and good catch—fixed.
amarshall-dd
force-pushed
the
ci-do-not-cancel-concurrent
branch
from
e46cc5e to
1a1dfd3
Compare
Failing fast makes it impossible to determine if the issue is specific to one job in the matrix or not, as we would never get the results from the others to compare.
amarshall-dd
force-pushed
the
ci-do-not-cancel-concurrent
branch
from
1a1dfd3 to
3246819
Compare
skarimo
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing fast makes it impossible to determine if the issue is specific to one job in the matrix or not, as we would never get the results from the others to compare.